Fixes an issue where the generated REST client was missing a comma #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between `additional-request-args` and `@Url` when both were used, causing a compilation error. Updated the `api.qute` template to handle this safely, without affecting other parameter combinations.
Member
|
@dellamas the CI is red, mind taking a look first? |
Contributor
Author
Yes, @ricardozanini , I will work on the correction between today and tomorrow. Thanks for the feedback. |
…gth > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations.
…gth > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations.
ricardozanini
approved these changes
Jun 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…1170) * Fixes an issue where the generated REST client was missing a comma between `additional-request-args` and `@Url` when both were used, causing a compilation error. Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations.
ricardozanini
pushed a commit
that referenced
this pull request
Jun 10, 2025
…1170) (#1178) * Fixes an issue where the generated REST client was missing a comma between `additional-request-args` and `@Url` when both were used, causing a compilation error. Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. Co-authored-by: Luis Fabrício De Llamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1161
When using both
additional-request-argsanduse-dynamic-url=true, the generated REST client method was missing a comma between the parameters, causing a compilation error.This update to the
api.qutetemplate ensures that:additionalRequestArgsand@Url